Skip to content

ENH: test vecdot conjugation #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

ev-br
Copy link
Member

@ev-br ev-br commented Feb 18, 2025

A small no-hypothsis test to make sure vecdot conjugates its first argument

This is a light-touch alternative to #323, which is blocked by the difficulties of value testing with hypothesis.

TODO:

  • update array-api-strict to >= 2.3.0, when available.

@ev-br ev-br changed the title ENH: test vectot conjugation ENH: test vecdot conjugation Feb 18, 2025
@ev-br ev-br force-pushed the vecdot_nohypothesis branch from 4be8364 to 2da7fff Compare February 18, 2025 13:01
@ev-br
Copy link
Member Author

ev-br commented Feb 18, 2025

CI fails with array-api-strict==2.2, passes locally with array-api-strict==2.3dev since the fix in -strict landed after 2.2 was cut.

@ev-br ev-br closed this Feb 27, 2025
@ev-br ev-br reopened this Feb 27, 2025
A small no-hypothsis test to make sure vecdot conjugates its first argument
@ev-br ev-br force-pushed the vecdot_nohypothesis branch from 2da7fff to 8c7f5de Compare February 27, 2025 10:37
@ev-br
Copy link
Member Author

ev-br commented Feb 27, 2025

Now that array-api-strict==2.3 is released, tests pass. Merging.

@ev-br ev-br merged commit 28e1982 into data-apis:master Feb 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant